Add friend list support #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacampbell
approved these changes
Apr 28, 2024
Arrowgene.Ddon.Shared/Entity/PacketStructure/C2SFriendRegisterFavoriteFriendReq.cs
Outdated
Show resolved
Hide resolved
| public override void Write(IBuffer buffer, S2CCharacterCommunityCharacterStatusGetRes obj) | ||
| { | ||
| WriteInt32(buffer, obj.Result); | ||
|
|
There was a problem hiding this comment.
nitpick: remove newline. Same request in other places.
alborrajo
requested changes
Apr 28, 2024
Arrowgene.Ddon.Database/Files/Database/Script/schema_sqlite.sql
Outdated
Show resolved
Hide resolved
Arrowgene.Ddon.Shared/Entity/PacketStructure/S2CFriendRemoveFriendNtc.cs
Outdated
Show resolved
Hide resolved
Arrowgene.Ddon.Shared/Entity/PacketStructure/S2CFriendCancelFriendApplicationNtc.cs
Outdated
Show resolved
Hide resolved
Arrowgene.Ddon.Shared/Entity/PacketStructure/S2CFriendApproveFriendNtc.cs
Outdated
Show resolved
Hide resolved
Arrowgene.Ddon.Shared/Entity/PacketStructure/S2CFriendApplyFriendNtc.cs
Outdated
Show resolved
Hide resolved
alborrajo
requested changes
Apr 28, 2024
alborrajo
approved these changes
Apr 28, 2024
pacampbell
approved these changes
Apr 28, 2024
|
|
||
| foreach (var f in friends) | ||
| { | ||
| if (f.Type != ContactListType.FriendList || f.Status != ContactListStatus.Accepted) continue; |
There was a problem hiding this comment.
I'm not a fan of these kind of unbracketed if statements. I've seen a lot of bugs where some other person comes to change and then made a mistake due to this kind of style. If Laith is ok with this though, then it is fine.
|
|
||
| foreach (var f in friends) | ||
| { | ||
| if (f.Type != ContactListType.FriendList) continue; |
There was a problem hiding this comment.
Same comment as above.
mjsalerno
force-pushed
the
feature/friend-list
branch
from
8a16cf2 to
9fc092b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for friend lists
Checklist:
developbranch